ggml-cpu: Pass on tag_name to the feature scoring #14332
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables scoring backends based on criteria other than instruction support such as platform name. An example would be backends built for generic "armv8.6-a", and for "neoverse-n1" which implements armv8.6-a. Scoring only by features, these could look identical, whereas a -mcpu=neoverse-n1 targeted build might be able to edge out extra performance or efficiency. The tag_name should be considered free-text. It is up to the scoring implementation to parse/extract relevant information.
github-actions
bot
added
the
ggml
|
I would prefer if this is merged at the same time that the code that is intended to use it is merged. As it is, this is non-functional. |
|
Yeah, I thought this might be an issue. My thinking was that trivial as this is, there are already a few design decisions (no cmake function interface changes, no structured values, no assumptions on how scoring uses this) that influence how the functional part might look like, it might be less work to get these out of the way first. I'll do an update with something that uses this. |
|
This turned out to be the wrong approach after all. It is superseded by #14380. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables scoring backends based on criteria other than instruction support, such as platform name.
An example would be backends built for generic "armv8.6-a", and for "neoverse-n1" which implements armv8.6-a. Scoring only by features, these could look identical, whereas a
-mcpu=neoverse-n1targeted build might be able to edge out extra performance or efficiency.The tag_name should be considered free-text. It is up to the scoring implementation to parse/extract relevant information.